Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 One Token Model - Pallet Funding Tests #402

Merged
merged 1 commit into from
Oct 10, 2024
Merged

🧪 One Token Model - Pallet Funding Tests #402

merged 1 commit into from
Oct 10, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 19, 2024 •
edited
Loading

What?

  • Change mock AccountId from u32 to u64
  • Test the OTM flow inside pallet-funding

Why?

  • PalletId account derivations start with a 32bit constant, so that meant the proxy-bonding escrow and the project_id escrow had the same account
  • So far we only tested the proxy-bonding in a vacuum.

Testing?

  • one_token_mode_bid_funding_success
  • one_token_mode_bid_funding_failed
  • one_token_mode_contribution_funding_success
  • one_token_mode_contribution_funding_failed

Anything Else?

e2e tests need to be updated with OTM values. In another PR

@JuaniRios JuaniRios mentioned this pull request Sep 19, 2024
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Sep 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Sep 19, 2024
Merged
@JuaniRios JuaniRios changed the title otm_funding_tests 🧪 OTM Funding tests Sep 19, 2024
@JuaniRios JuaniRios changed the title 🧪 OTM Funding tests 🧪One Token Model - pallet-funding tests Sep 19, 2024
@JuaniRios JuaniRios changed the title 🧪One Token Model - pallet-funding tests 🧪One Token Model - Pallet Funding Tests Sep 19, 2024
@JuaniRios JuaniRios changed the title 🧪One Token Model - Pallet Funding Tests 🧪 One Token Model - Pallet Funding Tests Sep 19, 2024
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 59622fb to 7b27337 Compare September 20, 2024 12:04
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 7b27337 to ae97cae Compare September 20, 2024 13:20
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from ae97cae to b9e0a82 Compare September 20, 2024 13:23
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from b9e0a82 to c96cdf6 Compare September 23, 2024 09:23
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from c96cdf6 to 0cce953 Compare September 23, 2024 10:49
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 0cce953 to a04bf46 Compare September 23, 2024 10:51
@JuaniRios JuaniRios force-pushed the 09-19-otm_funding_tests branch 4 times, most recently from 87b6edd to 362ed37 Compare September 24, 2024 09:02
@JuaniRios JuaniRios self-assigned this Sep 24, 2024
@JuaniRios JuaniRios force-pushed the 09-19-otm_funding_tests branch 2 times, most recently from 03aec7c to 9050fc9 Compare September 24, 2024 10:46
@JuaniRios JuaniRios marked this pull request as ready for review September 24, 2024 10:46
@JuaniRios JuaniRios mentioned this pull request Oct 4, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-19-otm_funding_tests branch 2 times, most recently from cbdb1d7 to 33630ab Compare October 4, 2024 12:17
@JuaniRios JuaniRios mentioned this pull request Oct 4, 2024
Closed
@JuaniRios JuaniRios mentioned this pull request Oct 7, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 70e3fed to 6a561be Compare October 9, 2024 09:59
This was referenced Oct 9, 2024
Merged
Merged
@lrazovic lrazovic force-pushed the 09-18-pallet_funding_otm_integration branch from 6a561be to 6836ed8 Compare October 10, 2024 11:57
@lrazovic lrazovic mentioned this pull request Oct 10, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 6836ed8 to 6a561be Compare October 10, 2024 11:59
@JuaniRios JuaniRios mentioned this pull request Oct 10, 2024
Merged
@lrazovic lrazovic force-pushed the 09-18-pallet_funding_otm_integration branch from 6a561be to 6836ed8 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 6836ed8 to 6a561be Compare October 10, 2024 12:22
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 6a561be to dd5ba75 Compare October 10, 2024 13:46
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Oct 10, 2024 •
edited
Loading

Merge activity

  • Oct 10, 10:08 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 10:13 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 10:14 AM EDT: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 09-18-pallet_funding_otm_integration to graphite-base/402 October 10, 2024 14:09
@JuaniRios JuaniRios changed the base branch from graphite-base/402 to main October 10, 2024 14:11
@JuaniRios JuaniRios merged commit 15efbfa into main Oct 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 09-19-otm_funding_tests branch October 10, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 vstam1 approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1